Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: [2.3] Remove HasCollection & HasPartition grpc call #651

Merged
merged 2 commits into from
Jan 16, 2024
Merged

enhance: [2.3] Remove HasCollection & HasPartition grpc call #651

merged 2 commits into from
Jan 16, 2024

Conversation

congqixia
Copy link
Contributor

See also: #650

@congqixia
enhance: Remove HasCollection & HasPartition grpc call
3829e84 
See also: milvus-io#650

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved review approved size/L Denotes a PR that changes 100-499 lines. labels Jan 15, 2024
@mergify mergify bot added the ci-passed auto merge needed label label Jan 15, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9e1483c) 74.95% compared to head (3829e84) 74.95%.

❗ Current head 3829e84 differs from pull request most recent head c1242d6. Consider uploading reports for the commit c1242d6 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           v2.3.x     #651      +/-   ##
==========================================
- Coverage   74.95%   74.95%   -0.01%     
==========================================
  Files          44       44              
  Lines        4125     4053      -72     
==========================================
- Hits         3092     3038      -54     
+ Misses        921      915       -6     
+ Partials      112      100      -12
Files Coverage Δ
client/collection.go 90.62% <ø> (+1.86%) ⬆️
client/data.go 70.78% <ø> (+0.23%) ⬆️
client/insert.go 79.52% <ø> (-0.48%) ⬇️
client/partition.go 87.23% <ø> (+3.16%) ⬆️
client/row.go 86.11% <ø> (-0.32%) ⬇️

... and 1 file with indirect coverage changes

@mergify mergify bot added ci-passed auto merge needed label and removed ci-passed auto merge needed label labels Jan 15, 2024
@mergify mergify bot added ci-passed auto merge needed label and removed ci-passed auto merge needed label labels Jan 16, 2024
@congqixia
Fix case error msg
c1242d6 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@mergify mergify bot added the ci-passed auto merge needed label label Jan 16, 2024
@congqixia
Copy link
Contributor Author

/kind enhancement

@sre-ci-robot sre-ci-robot added the kind/enhancement New feature or request label Jan 16, 2024
@congqixia
Copy link
Contributor Author

/hold

yah01
yah01 reviewed Jan 16, 2024
View reviewed changes
Copy link
Member

@yah01 yah01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Jan 16, 2024
@ThreadDao
Copy link
Contributor

/lgtm

@congqixia
Copy link
Contributor Author

/unhold

@sre-ci-robot sre-ci-robot merged commit 66ba4c6 into milvus-io:v2.3.x Jan 16, 2024
7 checks passed
@congqixia congqixia deleted the remove_internal_has_rpc branch February 20, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yah01 yah01 yah01 left review comments

@sunby sunby Awaiting requested review from sunby

Assignees

@yah01 yah01

@ThreadDao ThreadDao

Labels
approved review approved ci-passed auto merge needed label kind/enhancement New feature or request lgtm look good to me size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@congqixia @sre-ci-robot @ThreadDao @yah01